search

nidhaloff / igel

a delightful machine learning tool that allows you to train, test, and use models without writing code
https://igel.readthedocs.io/en/latest/
MIT License
3.09k stars 172 forks source link

Contributing Guide #75

Closed GouravWadhwa closed 3 years ago

GouravWadhwa commented 3 years ago

Description

In the Contributing Guide it is written to run poetry run tests which might be wrong and should be changed to poetry run pytest. Further running poetry run pytest also results in error even for the current code

Screenshot 2021-08-21 at 10 43 13 PM
GouravWadhwa commented 3 years ago

This might be happening because model results are being saved at ./igel/model_results whereas in assert command it trying to check whether the results are stored at ./igel/tests/test_igel/model_results I think this can be solved by changing the path in constants file.

nidhaloff commented 3 years ago

Hi, thanks for noticing this. Yes the right command is make test and not poetry run tests. I will fix this in the docs.