search

nidhaloff / igel

a delightful machine learning tool that allows you to train, test, and use models without writing code
https://igel.readthedocs.io/en/latest/
MIT License
3.09k stars 172 forks source link

CNN Support Added #94

Open Prasanna28Devadiga opened 3 years ago

Prasanna28Devadiga commented 3 years ago

Solves issue #77 Model is configured via the YAML file. Have provided an yaml file example. Tested on Colab. Utilising Keras ensured that we could support a variety of layers besides just the standard Conv2D. Have added docstrings as per the contributing guidelines @nidhaloff Is this adequate? Kindly give me a review

nidhaloff commented 3 years ago

@Prasanna28Devadiga Thanks for the PR. This looks better than the last one. I will review it in detail asap. I may add some comments if I found something that can be optimized or improved

Prasanna28Devadiga commented 3 years ago

@nidhaloff Thank you for the detailed review. This was extremely insightful. As a result I've noticed a few key areas where improvements can be made , and some bug fixes as well. I intend to fix these as soon as possible. I'll even add a few unit tests with the next commit. My university exams are due so might take a bit longer. Let me know if that's fine :)