nidi3 / graphviz-java

Use graphviz with pure java
Apache License 2.0
934 stars 106 forks source link

Updating batik-rasterizer to fix a vulnerability #184

Closed groph closed 3 years ago

groph commented 3 years ago

Updating batik-rasterizer to fix vulnerability in its dependency, batik-svgrasterizer.

Vulnerability finding: https://snyk.io/vuln/maven:org.apache.xmlgraphics%3Abatik-svgrasterizer

codecov-io commented 3 years ago

Codecov Report

Merging #184 into master will decrease coverage by 0.20%. The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #184      +/-   ##
============================================
- Coverage     81.63%   81.43%   -0.21%     
+ Complexity     1151     1148       -3     
============================================
  Files           104      104              
  Lines          3605     3598       -7     
  Branches        364      364              
============================================
- Hits           2943     2930      -13     
- Misses          461      467       +6     
  Partials        201      201              
Impacted Files Coverage Δ Complexity Δ
...n/java/guru/nidi/graphviz/service/SystemUtils.java 50.00% <0.00%> (-13.16%) 13.00% <0.00%> (-2.00%)
...ru/nidi/graphviz/engine/GraphvizCmdLineEngine.java 82.66% <0.00%> (-1.34%) 25.00% <0.00%> (ø%)
.../main/kotlin/guru/nidi/graphviz/KraphvizContext.kt 90.90% <0.00%> (-0.99%) 21.00% <0.00%> (ø%)
...lin/src/main/kotlin/guru/nidi/graphviz/Kraphviz.kt 100.00% <0.00%> (ø) 4.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e2c7cf6...0f77e1a. Read the comment docs.

fritsi commented 3 years ago

@nidi3 can you please review this change? Our security scan identified vulnerabilities in batik 1.10 so we would like to upgrade the version to 1.13 which doesn't have those vulnerabilities. See this for the description of the security issues. Thanks in advance.