search

nidi3 / raml-tester

Test if a request/response matches a given raml definition
Apache License 2.0
71 stars 14 forks source link

NPE in SecurityExtractor when using Basic Authentication #29

Closed ddossot closed 9 years ago

ddossot commented 9 years ago

This is related to #24

With this definition, which is valid in RAML:

securitySchemes:
  - basic:
      type: Basic Authentication

I receive:

java.lang.NullPointerException
    at guru.nidi.ramltester.core.SecurityExtractor.queryParameters(SecurityExtractor.java:46)
    at guru.nidi.ramltester.core.RamlChecker.checkQueryParameters(RamlChecker.java:146)
    at guru.nidi.ramltester.core.RamlChecker.checkRequest(RamlChecker.java:112)
    at guru.nidi.ramltester.core.RamlChecker.check(RamlChecker.java:68)

Until #24 gets done, I think raml-tester should ignore the schemes it can't check (maybe log a warning about it) instead of dying with an NPE.

nidi3 commented 9 years ago

The NPE is thrown for securitySchemes without describedBy. Clearly an error. Unknown schemes are ignored, as you suggest.