search

nidi3 / raml-tester

Test if a request/response matches a given raml definition
Apache License 2.0
71 stars 14 forks source link

Sources updated so it can compile and run against JDK6. #61

Closed dsteegen closed 8 years ago

dsteegen commented 8 years ago

Hi,

This pull request contains the changes that are necessary to compile against JDK6. It also requires the pull request for the parent pom where the source level is set to java 1.6. It was quite straight forward for make these changes as the biggest changes were only the diamond operator and the "try with resources".

nidi3 commented 8 years ago

Hi @dsteegen Thanks for your pull request. I see some people (including me sometimes) are still stuck with java 6. :-1: But I really like diamonds and try-with-resources. So I'm going to do some experiments keeping the sources 7 but compiling for 6 (see http://blog.nidi.guru/tech/java/2015/09/27/java-7-on-6/)

dsteegen commented 8 years ago

Hi @nidi3,

Thank you for the feedback. The solution described in your blog posts seems a nice alternative as well. I recognise the feelings you describe when talking about the older version of Websphere that the company is not willing to upgrade. It's exactly the same issue at my current day job :) In the meantime, I installed my version in our Nexus repository in order to already use the library within our projects. I already gained a lot of benefit as we are using a lot of RAML's these days. Thank you for building this great testing framework!

nidi3 commented 8 years ago

Ok, with the next release, there will be a second artifact with classifier jdk6 which is compatible (at least I hope so) with java 1.6

dsteegen commented 8 years ago

That's great! I'll look forward to it :-)