search

nidor1998 / s3sync

Full featured, very fast s3 synchornization CLI tool powered by rust
Apache License 2.0
11 stars 1 forks source link

feat: parse proxy authentication from http(s) proxy URLs. #24

Closed zicklag closed 1 month ago

zicklag commented 1 month ago

Nice work, thanks for sharing this project!

This update allows you to use proxies that require authentication.

nidor1998 commented 1 month ago

Thanks for you pull request.

I've tested the code and it works fine. https proxy is working fine. But http proxy is not working.

Because hyper-proxy write Authorization header (not Proxy-Authorization header) to the http proxy. https://github.com/tafia/hyper-proxy/blob/aca1e1f5546ed5530e1a72dc5e07c5ed4b6099b3/src/lib.rs#L199 I don't know why it implemented like this.

with the case of amazon s3, it is very rare to use http proxy. So I will check it command line parsing.

I will merge this pull request and modify the code to check the http proxy command line parsing for the next releas