search

nidtiw / EC-500-Building-Software

Techniques and processes for building software on different platforms
0 stars 0 forks source link

Code review #12

Open AngelaBubble opened 6 years ago

AngelaBubble commented 6 years ago

Data path is clear and well organized. But whats the different for pictures in resized and results file? All API calls works well. But the vision API didn't apply on the image get from twitter.

The major problem in your code is that you really should hide your twitter API keys.

I ran through three error cases: invalid twitter handle, twitter account with no photos, and invalid google vision api auth. For the first one and the second one, the program just returns the default error shown through terminal by twitter. You should insert a 'try' to show which error you are handling. The third one, it would get default error returned by google vision. You should do the same thing for google vision api.

AngelaBubble commented 6 years ago

Perfromance:

For google vision api, it also write what google vision api returns on the pictures, which is quite awesome.

For twitter api and ffmpeg is general works good excepts some extreme condition.