[BUG] When translating, the translation result will keep adding text.

codeAndxv commented 1 month ago

Thank you for wanting to report a bug! But before starting, ensure to check if this bug report respects the following requirements:

[x] It is written in English (I can translate what you say, but issues written in English are easier to read for the other users).
[x] There is not already a similar bug report among the open issues (if this is the case you can leave a comment describing your problem in more detail in that already opened issue)

Describe the bug When I type "你好啊世界如何看待目前的经济局势失业很严重大家都找不到工作未来会变的好吗", it is translated from Chinese to English. The translation results will always append text, just like the one I took in the screenshot. I'm using the latest v2.0.0 commit code ,6bf51c1e2f70

Screenshots

Smartphone (please complete the following information):

Device: xiaomi 12
Android OS version: Android 13
TTS used: No
Version of the app: 2.1.1

Additional context Add any other context about the problem here.

niedev commented 1 month ago

Thank you for reporting this bug, I will investigate on this.

codeAndxv commented 1 month ago

Thank you for reporting this bug, I will investigate on this.

Hi, is this problem difficult to solve, and can you estimate how long it will take to resolve it? Because this issue occurs frequently, it's quite troublesome for me. Thanks! By the way, if you need help, I know some Java and Android.

niedev commented 1 month ago

I did some testing and the problem seems to be due to the quantization of the models (and greater for Chinese), which would make it quite difficult to solve. However I tried adding a period at the end of the sentence that gave you problems and in that case the problem goes away. For now you could try to always add a period at the end of input sentences, let me know if this solves or reduces the problem, in that case I will make an update in which the app will automatically add a period at the end of sentences when needed.

Thanks again.

codeAndxv commented 4 weeks ago

In addition to adding a full stop at the end, and forcibly breaking the entered text.

I tried to add the java code snapper below in this place. Without modifying the model, this problem can be solved.

if (j > 2 * input.getInputIDs().length) {
      android.util.Log.i("decoder", "Reach max tokenId count: " + 2 * input.getInputIDs().length + ", maybe occur error, break while.");
      break;
}

But the root cause is a model problem.

niedev commented 4 weeks ago

@codeAndxv Thank you for your input, this would definitely help. I'll try this change and others next week (I started a new job so I don't have much time, but I should be able to get around to it).

niedev commented 3 weeks ago

The new release that should mitigate this problem is out 🚀, let me know if the problem occurs less.

codeAndxv commented 3 weeks ago

It look fine, Thanks.

zhl111 commented 2 weeks ago

SmartSelect_20241103_173748_RTranslator After I said one sentence, everything turned gray and nothing clicked except the return key.