search

niekis / pe

0 stars 0 forks source link

Tag not allowing whitespace or dashes #6

Open niekis opened 1 year ago

niekis commented 1 year ago

Tag does not allow whitespace or dashes which are resonable for a user to want to add

image.png

nus-se-script commented 1 year ago

Team's Response

Thank you for raising this, however, we believe this is more of a preference than a suggestion.

The standard convention for tags in general is to not allow spaces. We have similarly adhered to AB3's design. Although we understand from your perspective it might be reasonable, we believe this is an issue of preference and more of a suggestion than an actual flaw.

Furthermore, we are following standard coding conventions as seen below.

Screenshot 2023-04-17 at 6.23.12 PM.png

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: Thanks for the response!

Apologies, but I don't understand how standard coding conventions (especially regarding tags in XML) would affect the User's expectations while using the application. In the case of XML, tag actually refers to code related terminology. In constrast, for the case of the application, tags refer to a piece of information tagged to a person.

It is unusual that certain fields (i.e address and name) can take in whitespace and dashes, while tags are unable to.

This might be inconvenient for some users under certain circumstances. For instance: in the UG, athletes were tagged with names of sports as an example. image.png

Therefore it seems quite reasonable to tag an athlete as a player of table tennis which has two words, or at least as table-tennis. However, the current implementation of tags hinders the user from saving it in this way and can be considered as undesirable behavior (i.e. a feature flaw), or at least inconvenient while they have to figure out a new way of saving such information.