niekis / pe

0 stars 0 forks source link

All contacts listed after using delete command #9

Open niekis opened 1 year ago

niekis commented 1 year ago

If the user calls find john image.png

the user then uses delete 1 command. But this will cause all entries to show up again.

image.png

This could be undesirable if the user is trying to delete all john entries. (Has to find each time before deleting)

user could also accidentally delete the wrong entry, if they are not paying attention

soc-pe-bot commented 1 year ago

Team's Response

This is not a flaw as we intended it as such. If we take your suggestion, this would be undesirable for many other users because they would have to manually type in "list" again after deleting the contact through "find". We believe the case of deleting multiple people of the same name is more unlikely to occur, and it is more likely that the user would want to view the full list again after deleting a certain individual. Hence, we chose to show the full list of contacts after deleting a contact.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: Thanks for the response!

I think that the scenario of deleting multiple people after a search is done is not that unlikely. For instance, if parents of pair of siblings have decided to change their trainer, a user might want to find both siblings using their surname and want to delete them both. Since the user would be a fast typist, they could quickly use delete 1 twice in a row, accidentally deleting the wrong athlete the second time around.

image.png

after deleting Sarah Mcfee, they would accidentally delete Roy instead of Lee Mcfee.

image.png

Another very plausible example where all the contacts being showed after deletion could be quite inconvenient could occur when a trainer has just finished their last session with a group of baseball players that are about to graduate, and thus would not require anymore training. The user would use show baseball to show every athlete with the tag, and proceed to delete all of the players with that tag.

image.png

As a new user, it was also more intuitive to me that I need to type list again to view all of the contacts after using find or show. In fact, listing all the contacts left me more unsure if the app had actually deleted the correct athlete, causing me to check the whole list again to see if it was really deleted. It just seems unintuitive to me that the app would call the list command on my behalf after doing a deletion, especially since that might only be desirable half the time.

I think that this design choice could make sense in the scenario where the temporary list (post find/show) is made empty after a deletion, however, there would still be a tradeoff with clarity. Under normal circumstances (where the temporary list still has some contacts remaining), this design choice feels less intuitive to me, and I feel that it is more inconvenient for the user overall (since you are trading clarity for a small bit of convenience).