As you requested, here's a review of your vgmrecorder.tcl script. I'm not sure if doing a review as a github pull request is the best idea, but it's an experiment.
See the commit message of each commit for more details. I tried to make only one type of change per commit. I also tried to explain what I did in each commit. Feel free to ask for more info if anything is unclear.
Maybe not all these commits are useful to you. E.g. some of them are pure stylistic cleanups. Feel free to cherry-pick only those commits you like.
I only did _verybrief testing on the modified script. I basically only executed vgm_rec vgm_rec_end, checked that there were no Tcl errors and checked that there was a .vgm file created. But I did not check whether the content of that file was still correct.
Hi,
As you requested, here's a review of your vgmrecorder.tcl script. I'm not sure if doing a review as a github pull request is the best idea, but it's an experiment.
See the commit message of each commit for more details. I tried to make only one type of change per commit. I also tried to explain what I did in each commit. Feel free to ask for more info if anything is unclear.
Maybe not all these commits are useful to you. E.g. some of them are pure stylistic cleanups. Feel free to cherry-pick only those commits you like.
I only did _verybrief testing on the modified script. I basically only executed vgm_rec vgm_rec_end, checked that there were no Tcl errors and checked that there was a .vgm file created. But I did not check whether the content of that file was still correct.
I hope this is useful to you.
Wouter