nieldlr / hanzi

HanziJS is a Chinese character and NLP module for Chinese language processing for Node.js

http://hanzijs.com

MIT License

375 stars 56 forks source link

Add tooling for TravisCI, Codecov.io #37

Closed zurawiki closed 6 years ago

zurawiki commented 7 years ago

Added npm scripts for getting coverage reports Setup Travis yml file to support CI

I have no affiliation with either company and I am not receiving any kind of reward for integrating these product into this open source project. I am suggesting this change because I think it will be useful to contributors. Note both products are free for open source projects.

With every new PR we will be able to see if the changes passes tests and we can investigate how new change affect our code coverage.

After merging this branch, a few changes will still be required from your end @nieldlr

1) Setup a TravisCI account and enable CI for this repo. Instructions here: https://docs.travis-ci.com/user/getting-started/

2) Setup a codecov.io account and enable coverage reports for this repo. codecov.io should automatically detect the TravisCI instance on this repo

zurawiki commented 7 years ago

@nieldlr Quick bump for this PR.

It is not blocked on any other PRs. It just needs you to sign up for those two accounts

nieldlr commented 7 years ago

@zurawiki awesome. I like these suggestions. I'll sign up for those today & set those up.

zurawiki commented 7 years ago

@nieldlr I just rebased again so this PR should be good to merge

nieldlr commented 7 years ago

Heya @zurawiki, I think I have this all set up now. Not sure if I missed anything? Travis - https://travis-ci.org/nieldlr/Hanzi CodeCov - https://codecov.io/gh/nieldlr/Hanzi

I left one comment where I think a small typo needs to be fixed.

codecov-io commented 6 years ago

Codecov Report

Merging #37 into master will not change coverage. The diff coverage is n/a.

@@          Coverage Diff           @@
##           master     #37   +/-   ##
======================================
  Coverage    87.4%   87.4%           
======================================
  Files          10      10           
  Lines         524     524           
  Branches       86      86           
======================================
  Hits          458     458           
  Misses         54      54           
  Partials       12      12

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f730735...74b08f3. Read the comment docs.

zurawiki commented 6 years ago

Rebased this PR onto v2.0.0

nieldlr commented 6 years ago

Thanks for updating this @zurawiki 👌