codecov-io commented 5 years ago

Codecov Report

Merging #58 into master will not change coverage. The diff coverage is 100%.

@@           Coverage Diff           @@
##           master      #58   +/-   ##
=======================================
  Coverage   87.77%   87.77%           
=======================================
  Files          15       15           
  Lines         548      548           
  Branches       91       91           
=======================================
  Hits          481      481           
  Misses         55       55           
  Partials       12       12

Impacted Files	Coverage Δ
lib/dictionary.js	`87.98% <100%> (ø)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8b80e6d...0946112. Read the comment docs.

benlieb commented 3 weeks ago

I'm running into this issue with Chrome Extension V3 as well:

It's blocking my whole extension from running now. Is there a workaround for this?

@bensmiley

benlieb commented 3 weeks ago

@nieldlr It looks like this is now a critical issue now. Any possibility you'll merge this or should I fork? I'd rather not fork, but my PR from 2020 also still hasn't been responded to. https://github.com/nieldlr/hanzi/pull/60

Are you open to adding maintainers?

nieldlr commented 3 weeks ago

Hi @benlieb,

sorry about this. I've haven't been focused on this for a while, but I definitely don't want it to be a blocker. I've merged this fix. Do you need this update published to npm as well?

I'm not currently looking for maintainers. But I also don't want to a bottleneck here. I'll reflect on this a bit and potentially find a way forward.

nieldlr / hanzi

Fix small issue where variable hasn't been declared with var #58

Codecov Report