niels747 / 2D-Weather-Sandbox

Two-dimensional, realtime, interactive simulation of earth's troposphere.
https://niels747.github.io/2D-Weather-Sandbox/
GNU General Public License v3.0
81 stars 27 forks source link

Snow is Yellow #65

Closed MET905 closed 1 year ago

MET905 commented 1 year ago

bug

MET905 commented 1 year ago

This bug made me laugh, all I could think of was pee in the snow lol!

niels747 commented 1 year ago

Ow, that's not right indeed. Please tell me your system and browser specs.

MET905 commented 1 year ago

Sorry for the late response man, I'm using Firefox and I have a gaming PC, I can't remember the specs as I'm not at my Computer right now.

JustLearninglol commented 1 year ago

I think it’s god’s pee

niels747 commented 1 year ago

Since I am the "god" I can confirm it's not. In all seriousness I think this issue might only happen on AMD radeon gpu's...

MET905 commented 1 year ago

Weird, this bug started right after your last update. My PC has a NVIDA GeoForce GTX 1070

mesochaser2425 commented 1 year ago

i too have the same problem

MET905 commented 1 year ago

Im glad im not the only one.

niels747 commented 1 year ago

Weird, this bug started right after your last update. My PC has a NVIDA GeoForce GTX 1070

That's really wierd since I also have a GTX 1070 and I obviously don't have that problem. Are you sure your browser isn't using integrated graphics you might also have?

mesochaser2425 commented 1 year ago

i have radeon 490 xfx \

MET905 commented 1 year ago

I tried that still no change. My browser is using the highest performance.

Aerosoft8 commented 1 year ago

I see this yellow color when snow shifts to rain. Most likely a bug in the code?

MET905 commented 1 year ago

100% code related

niels747 commented 1 year ago

I found the issue, it only happened if you changed the stock snow density to more than 0.5!

It is displayed yellow when the density is > 0.5 and it's pure ice: https://github.com/niels747/2D-Weather-Sandbox/blob/dd74c76ff33689c13d7ee1b5a8a599d50ee20fae/shaders/fragment/precipDisplayShader.frag#L35 Will commit fix now

MET905 commented 1 year ago

Thank you Niels