search

nielsbasjes / codeowners

A library to use and verify the CODEOWNERS and .gitignore files
Apache License 2.0
5 stars 4 forks source link

Remove commons-io in favor of JDK 11+ features #123

Closed vincentjames501 closed 1 month ago

vincentjames501 commented 1 month ago

For whatever reason I couldn't get this project to build locally even after tweaking plugins, toolchains, etc. I'd love to see this as a zero dependency project as I'd like to use this more easily w/in the Clojure ecosystem with Babashka.

nielsbasjes commented 1 month ago

I like what you are trying to do here. I disagree with some of the technical how things, but I like the idea. I'll have a look at this

nielsbasjes commented 1 month ago

As said I like this idea; yet at this time I'm not going to make this change.

The simple reason is that one of the users of this library is the Apache Maven RAT plugin (Release Audit Tool) that because of the need for very wide compatibility needs to stay on Java 8.

https://github.com/apache/creadur-rat/blob/master/apache-rat-plugin/pom.xml#L383-L387

nielsbasjes commented 1 month ago

I have made some changes and the commons-io has been removed.