nielsboecker / HoloRepository-Core

A system for transforming medical imaging studies into holograms, storing them in the cloud and providing them to other systems.
GNU Affero General Public License v3.0
6 stars 8 forks source link

PIPELINE: Draft version for the API #34

Closed ansonwong9695 closed 5 years ago

ansonwong9695 commented 5 years ago

Created 3 endpoints for the front end

Create 1 endpoints to update the status internally

Other functionality -create the clean up function for the status, if job exist more than 20 mins will be deleted. -pipeline when finished the task it will send the request to the hologram (have not tested it)

nielsboecker commented 5 years ago

Good morning :) Thanks for opening the PR, Kawai. Some general remarks:

nielsboecker commented 5 years ago

@ansonwong9695, @UdomkarnBoonyaprasert: I have some other TODOs for you guys; we can track them in this post and cross them out when you finished them:

nielsboecker commented 5 years ago

Sorry @ansonwong9695, I realised that the build for your work was broken all along. I fixed several issues with the imports, but the tests still fail. I think it is because you changed the main method signature (using the object to bundle all the arguments). But you did not change the tests to reflect that. Can you please update the tests?

nielsboecker commented 5 years ago

Update: I found that the tests fail for different reasons actually, including @UdomkarnBoonyaprasert's changes. It's a big, big, mess to be honest. I disabled the tests for now, and you can fix them later (in a different branch!)

nielsboecker commented 5 years ago

Note that there are still many issues in this branch at the time of merging, especially in compJobPath. I am merging it now to prevent future merge conflicts, as I am doing a heavy refactoring in #45 . In that branch I also fix most issues. The "compJobPath" issues can be solved in #59.