search

nielsboecker / HoloRepository-Core

A system for transforming medical imaging studies into holograms, storing them in the cloud and providing them to other systems.
GNU Affero General Public License v3.0
6 stars 8 forks source link

PIPELINE: Wrong coupling of functionalities (resampling) #46

Closed nielsboecker closed 5 years ago

nielsboecker commented 5 years ago

Description

The way the code is currently mixing functionality, where one component does multiple things, has led to strange and unwanted dependencies.

For example, in the adominal organ pipeline, the compNifty2Numpy performs a resampling, even though it is not needed. It has already performed by compDicom2Nifty, and the only reason that it runs again, is that it is "hard wired" into compNifty2Numpy.

While this is only a small performance issue, as all computations have already been done, it is bad design and needs to be fixed.

nielsboecker commented 5 years ago

Resolving this issue is one of the sub-goals of #45

nielsboecker commented 5 years ago

I fixed this for #45 in 8bae93894fce874042db63141f49a54c0e6b4a19.

@UdomkarnBoonyaprasert could you confirm that my fix makes sense, and that you ran it and nothing broke, so we still get the same output?

nielsboecker commented 5 years ago

I take your silence as a yes.