nielsboecker / HoloRepository-Core

A system for transforming medical imaging studies into holograms, storing them in the cloud and providing them to other systems.
GNU Affero General Public License v3.0
6 stars 8 forks source link

PIPELINE: Better logging is needed #50

Closed nielsboecker closed 5 years ago

nielsboecker commented 5 years ago

Description

Currently, it is hard to understand which step takes how much time, and there are some that take a lot (multiple minutes). It is important to know this, as some tasks take very long, and we need to understand what takes how long.

Note: To be done after #34 is finished.

Suggested solution 1

Maybe we can include this in the "housekeeping" we do for job status. So when the status of a job changes from x to y, we could do two log statements

[DEBUG] [Job 123] Finished 'x' in 6313 ms
[DEBUG] [Job 123] Starting stage 'y'

Suggested solution 2

Use some kind of decorator.

The benefit of this would be that it can also easliy be applied to other levels of granularity, so e.g. give an output how long a complete pipeline ran. And it could be easier to implement 🤵

nielsboecker commented 5 years ago

I'm doing this as part of #45