PIPELINE: Fix tests and increase test coverage

nielsboecker / HoloRepository-Core

A system for transforming medical imaging studies into holograms, storing them in the cloud and providing them to other systems.

GNU Affero General Public License v3.0

6 stars 8 forks source link

PIPELINE: Fix tests and increase test coverage #55

Closed nielsboecker closed 5 years ago

nielsboecker commented 5 years ago

Many major code changes were made without updating the tests on @UdomkarnBoonyaprasert and @ansonwong9695's end. I disabled broken tests for now and commented what the issues seem to be. This needs fixing.

nielsboecker commented 5 years ago

Update: With the refactoring in #45 almost all tests are outdated (in addition to being broken 🤣). So new tests will need to be written.

The good news is that the new modular structure and decoupling from all the subprocess hell makes everything much more testable.

nielsboecker commented 5 years ago

Update: With #75, test coverage comes back to 73%. I am closing this issue, as the worst is now behind us. However, tests should be improved:

The pipeline tests should have more assertions (make sure all components were called, expected files created, etc.)
The other components should be tested independently and with actual, valuable assertions
The jobs-specific stuff (as opposed to the core package) needs to be tested

@UdomkarnBoonyaprasert, @ansonwong9695 FYI