search

nielsboecker / HoloRepository-Core

A system for transforming medical imaging studies into holograms, storing them in the cloud and providing them to other systems.
GNU Affero General Public License v3.0
6 stars 8 forks source link

Pipeline: Update NumPy array cropping condition #77

Closed UdomkarnBoonyaprasert closed 5 years ago

UdomkarnBoonyaprasert commented 5 years ago

Cropping is now done if any of the dimensions is not divisible by 8. This is to address issue #56

nielsboecker commented 5 years ago

@UdomkarnBoonyaprasert Code looks great now 👍. How about adding a test before we close the issue? To assert the different scenarios work:

np_image_manipulation_test.py
    test_crop_around_centre
    test_downscale_and_conditionally_crop_with_only_downscale
    test_downscale_and_conditionally_crop_with_downscale_and_crop
    test_downscale_and_conditionally_crop_with_only_crop