Closed dependabot[bot] closed 5 years ago
Hey @fanbomeng97 I opened this auto-fix PR created by GitHub to fix a security vulnerability. Could you please just verify if the server still runs as expected? Build pipeline has already passed
Cannot run it with npm start
But npm run dev
works well
I tested it on my machine and it seems to work. I think your issue is that npm run start
is only meant to be ran after running npm run compile
. It is meant for production so you'd have to compile/build first.
// from package.json
"scripts": {
"start": "node dist/src/index.js",
"compile": "ts-node prepareBuild.ts && tsc",
"dev": "nodemon src/index.ts | pino-pretty"
}
oh, I forgot compile it, so stupid... Works well now
No problem, it is actually quite confusing because the start
command for the react app does everything, so it's different semantics.
I'll merge this fix then, thanks for confirming.
Bumps eslint-utils from 1.4.0 to 1.4.2.
Commits
- [`4e1bc07`](https://github.com/mysticatea/eslint-utils/commit/4e1bc077c2a6bb00538d66b69a63c24de3463bed) 1.4.2 - [`e4cb014`](https://github.com/mysticatea/eslint-utils/commit/e4cb01498df6096b66edb0c78965ee6f47d3ac77) π add null test - [`230a4e2`](https://github.com/mysticatea/eslint-utils/commit/230a4e2275cde169cbfbb95cd2e4de2152fae0a2) 1.4.1 - [`08158db`](https://github.com/mysticatea/eslint-utils/commit/08158db1c98fd71cf0f32ddefbc147e2620e724c) π fix getStaticValue security issue - [`587cca2`](https://github.com/mysticatea/eslint-utils/commit/587cca2f82c245f5fc4a8b9fb2cf6b35c0d02552) π fix getStringIfConstant to handle literals correctly - [`c119e83`](https://github.com/mysticatea/eslint-utils/commit/c119e832952c8c653bd4f21e39eb9f7ce48e5947) π fix getStaticValue to handle bigint correctly - See full diff in [compare view](https://github.com/mysticatea/eslint-utils/compare/v1.4.0...v1.4.2)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot ignore this [patch|minor|major] version` will close this PR and stop Dependabot creating any more for this minor/major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) - `@dependabot use these labels` will set the current labels as the default for future PRs for this repo and language - `@dependabot use these reviewers` will set the current reviewers as the default for future PRs for this repo and language - `@dependabot use these assignees` will set the current assignees as the default for future PRs for this repo and language - `@dependabot use this milestone` will set the current milestone as the default for future PRs for this repo and language You can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/nbckr/HoloRepository-Core/network/alerts).