PIPELINE: Use HTTP client in receive_input task

nielsboecker / HoloRepository-Core

A system for transforming medical imaging studies into holograms, storing them in the cloud and providing them to other systems.

GNU Affero General Public License v3.0

7 stars 8 forks source link

PIPELINE: Use HTTP client in receive_input task #83

Closed nielsboecker closed 5 years ago

nielsboecker commented 5 years ago

http_client was extracted in a PR. I then realised that I introduced duplicate code, so refactored it.

PS: The "shared tasks" are currently really only redirecting to other components. I think it's okay to leave it as is, and was thinking that in the future they can be used to make the pipelines even more generic (always just plug together a couple of tasks, without knowing if it's a wrapper, client, service...) but if it bothers you in its current state, they could be removed and replaced with the direct calls in the pipelines.

boonwj commented 5 years ago

This refactor breaks the download process.

holopipelines-core_1                             | 2019-09-08 10:56:51 | root | INFO  | Download of 'https://holoblob.blob.core.windows.net/mock-pacs/left-scfe-pelvis-bone.zip' was successful
holopipelines-core_1                             | 2019-09-08 10:56:51 | root | WARNING | [ERROR] An error occurred and caused the job to fail: type object 'bytes' has no attribute 'seek'

nielsboecker commented 5 years ago

@boonwj Try again, please. I fixed what appears to be a rather obvious bug, and verified with a simple Postman request on my machine that the pipeline download and extraction works.