search

nielsenramon / chalk

Chalk is a high quality, completely customizable, performant and 100% free Jekyll blog theme.
http://chalk.nielsenramon.com
MIT License
1.23k stars 442 forks source link

Revert #119 #121

Closed nielsenramon closed 6 years ago

nielsenramon commented 6 years ago

Revert the change here: https://github.com/nielsenramon/chalk/pull/119

migueldemoura commented 6 years ago

To paraphrase what was said on that PR, we should probably upgrade to jekyll-assets v3, the breaking changes are trivial to fix and are contained here: https://github.com/migueldemoura/migueldemoura.com/commit/6c498dbbe53a2f17db3d34848a6a3716261953cc

nielsenramon commented 6 years ago

@migueldemoura Now that I updated to jekyll Assets 3, should I remove the baseurl?

migueldemoura commented 6 years ago

One could keep the baseurl key empty, along with a comment, as that might help out new users.