search

nielsenramon / chalk

Chalk is a high quality, completely customizable, performant and 100% free Jekyll blog theme.
http://chalk.nielsenramon.com
MIT License
1.22k stars 441 forks source link

Wrap tag list with div #176

Closed KOREAN139 closed 5 years ago

KOREAN139 commented 6 years ago

wrap tag list with div.article-list-tags to keep page design generality in chalk

nielsenramon commented 6 years ago

@KOREAN139 Would it be possible to show me a before and after screenshot please? :)

KOREAN139 commented 6 years ago

@nielsenramon That was so unkind description, sorry.

here is my monitor & browser info. - MacBook Pro Retina 15-inch 2015, safari.

It has no difference before & after commit in full-size window safari.

When the browser becomes smaller (I found this in halfleft-size. This situation appears when window is too narrow to print date - [n] minute read - tag list in one line), there is no space between [n] minute read and tag list like this. before_narrow_articles_by_tag

While the main page forms tag list like this. before_narrow_home

So i wrapped for-loop which prints tag with div.article-list-tags, and this made articles-by-tag page can form tag list in the same way which main page does. after_narrow_articles_by_tag

nielsenramon commented 5 years ago

Fixed in another pr!