search

nielsfaber / alarmo

Easy to use alarm system integration for Home Assistant
1.35k stars 122 forks source link

alarmo 1.6.1 BUG in actions #224

Closed cokeman0 closed 3 years ago

cokeman0 commented 3 years ago

Hi trying to make a "turn on siren" work 24/7 (smokes sensors)

When trying to save this, I get this error

image

nielsfaber commented 3 years ago

Missing some context to be able to help. Are you editing an older notification, or creating a new one? Which modes show up in the list?

cokeman0 commented 3 years ago

I have tried both. change old, and create a new

image

and deleting the items, and the list shows up as:

image

Here I have created a new action: image

nielsfaber commented 3 years ago

Ah, I'm finally able to see the same problem: image

I will work on a fix.

nielsfaber commented 3 years ago

I fixed it locally https://github.com/nielsfaber/alarmo/commit/670cc8c49b645c71c040c21c41df6e5a9cd603c8 I will release a new update in the upcoming days which should fix this. In the meantime you need to have at least 1 mode selected, otherwise you're not able to save.

cokeman0 commented 3 years ago

Thanks, we hope soon, as this trigger with "none or all" is needed to trigger the sirens if/when a smoke sensor detects smoke

cokeman0 commented 3 years ago

Sorry, the fix is not complete.

When trying to remove both modes so there is no restrictions on when the action will run, smoke sensor, it still add both modes back to the list.

Please try to make a new action, remove all restrictions, and save it. When you look at it again, You will then find that is will only trigger armed_home and armed_home.

I need it to trigger always if a environment sensor triggers, and instantly 😄

nielsfaber commented 3 years ago

I will take another look at this 👍

nielsfaber commented 3 years ago

In my test instance of HA I set up the front door as environmental sensor

image

Action is set up to execute regardless of the arm mode: image

After saving, the siren is indeed switched on by the frontdoor, while the system is disarmed. So the functionality is OK.

But when returning to the action, I see that the modes are filled in: image

It seems more a display issue than functionality issue. But I agree that it is not pleasant (especially because after editing you will have to remove the arm modes again).

nielsfaber commented 3 years ago

Fix is on the way https://github.com/nielsfaber/alarmo/commit/a6ae72575b5245ee3bd9722a23f0bd9bec205cee