nielsfaber / alarmo

Easy to use alarm system integration for Home Assistant
1.31k stars 119 forks source link

Actions panel hierarchy/structure re-work #349

Closed trankillity closed 2 years ago

trankillity commented 2 years ago

Checklist

Proposal

I believe the Actions panel (and the documentation for the Advanced Actions) are more convoluted than they need to be. An action automation should always be a reaction to an event occurring, so logically it should flow trigger event -> action(s). Using this philosophy, you can remove the separation between the two current action types (notifications and actions) and make the Actions panel function more like the standard HA automations panel, with multiple actions per trigger. I feel like this would make the flow significantly clearer/easier and would be more inline with the standard HA implementation of trigger event -> action(s).

Additional info

A few examples of how the flow would work:

nielsfaber commented 2 years ago

We are not on the same page with this. I don't think it is wise to make a copy of the HA automation editor. It would involve a lot of effort and maintenance, which I am not looking for.

I prefer to limit the support to basic tasks with a simple interface, and advise to using HA automations for anything that goes beyond what's possible from within Alarmo. If you ask me, the HA automation editor is bloated by having too many things which can be configured.

To respond to your use-cases:

trankillity commented 2 years ago

I think there may be some confusion here. The examples were purely that, examples. The examples weren't what I was requesting. More a logical restructuring of how the Actions panel works.

As mentioned in the original description, all actions are a result of an event occurring, so there's no logical reason that you should have to duplicate actions over events based on whether the action you want to fire are notifications or actions. This would drastically reduce the number of actions needed to achieve the desired results.

This would involve two main aspects:

Let's take an overly simplified example using the current UI to really illustrate it: Send a notification to an Android phone and an iOS phone, then turn on a light when the alarm is triggered.

Current Implementation

Result: Three automations for one event

Proposed Implementation

Result: One automation for one event

github-actions[bot] commented 2 years ago

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days