FR: enable entities per schedule, to avoid confusion showing schedules in new cards

nielsfaber / scheduler-card

HA Lovelace card for control of scheduler entities

GNU General Public License v3.0

926 stars 117 forks source link

FR: enable entities per schedule, to avoid confusion showing schedules in new cards #786

Closed erkr closed 6 months ago

erkr commented 10 months ago

Checklist

[X] I checked for similar existing issues (both open and closed) before posting.
[X] I will participate in further discussion about this issue and can help by testing (if requested).

Card Version

V3.2.12

Component Version

No response

Bug description

I removed all tags for a scheduler card. Even after a refresh of the browser, the previous tag filter remains active. This is what I get when I open the code editor on the card: Marked with green, although no tags, part of the schedules are hidden

Steps to reproduce

Remove tags from the card options

Additional info

No response

erkr commented 10 months ago

Update: I found out this happens as the schedules that remain hidden use entities that are not enabled in the new card. This is quite confusing when creating a card, where I enable the option to use existing schedules, but noting happens unless I add all entities used to the card. Proposal: Automatically include all entities used by schedules, when enabling that option to use existing schedules

github-actions[bot] commented 9 months ago

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days

erkr commented 9 months ago

@nielsfaber It would be nice if you have time to look to this issue. It's confusing. I thought a little longer about this and I think that entity selection in the card is not really logic. I think it should be per schedule. But I can imaging technically that it's not easy.

github-actions[bot] commented 8 months ago

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days

erkr commented 8 months ago

It would be nice to hear of this is something to fix

nielsfaber commented 8 months ago

I did not respond to this issue since it seems there is no bug reported here, instead you expected the behaviour to be different than how it is implemented.

What you are experiencing seems to have nothing to do with tags. If you don’t like the ‘X excluded items’ you have two options:

set discover_existing to false to hide the text
add the entities used by the discovered schedules to your include list

erkr commented 8 months ago

Hi Niels,

You are right. Initially I thought it was a bug, later I found out this happened due entities where are not enabled in the new card.

So it is a confusing mechanism to enable entities per card. I will make it a FR to select entities per schedule.

Best Eric

github-actions[bot] commented 7 months ago

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days

erkr commented 7 months ago

Still valid, but Niels, feel free to close it if you won't pick it up. No hard feelings, it's probably a huge chance

github-actions[bot] commented 6 months ago

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days