search

nielsfaber / scheduler-component

Custom component for HA that enables the creation of scheduler entities
GNU General Public License v3.0
662 stars 43 forks source link

Existing schedule does not accept new time #14

Closed juan11perez closed 4 years ago

juan11perez commented 4 years ago

want to share what may be a bug, unless i’m overlooking something. Once you create a schedule, if you go back later and change the time, it doesn’t change. It will only respect the originally created time input.

nielsfaber commented 4 years ago

Can you reproduce this problem? If so, could you share the steps that lead to this behaviour. I have never seen or heard anything like this.

juan11perez commented 4 years ago

Sure, thank you. So you create a schedule/switch. In this example i didnt change the time. So it was set at 12:00 I then went back and change the time to 13:20 Screenshot_2020-09-07_13-13-16

but whist the card does show 13:20. The entity stays at 12:00

Screenshot_2020-09-07_13-12-36

So this example will only trigger at 12 as initially selected.

nielsfaber commented 4 years ago

You’re absolutely right. The ‘next trigger’ looks out of sync, it keeps the old value. I’m fairly sure that the actions will also fire at 12:00 still, I’m surprised no one else (including me) ever noticed this. I will have to dive into this, might take some time to figure it out.

juan11perez commented 4 years ago

Yes, it triggers at the originally selected time. In this case 12:00 Thank you for your response.

jossiee commented 4 years ago

same issue here,

just to add to the above if you turn the schedule off and back on the new time will be picked up from the card.

nielsfaber commented 4 years ago

Sorry about the delay. I found the cause of this issue. I fixed it in v2.0.1

juan11perez commented 4 years ago

Thank you very much for the fix and consideration