search

nielsfaber / scheduler-component

Custom component for HA that enables the creation of scheduler entities
GNU General Public License v3.0
634 stars 41 forks source link

public holiday #196

Closed Micha-Btz closed 2 years ago

Micha-Btz commented 2 years ago

In Germany the 18.4.2022 is Easter Monday a public holiday day. I have created schedules for heating on Weekend and one for Mo-We. So the scheduled action in use should be Mo-We, but even the Weekend is triggered. Maybe because of the workday sensor is off.

maybe related to https://github.com/nielsfaber/scheduler-component/issues/187

Checklist

Expected behavior

only on Weekend

Actual behavior

on weekend and public holiday.

Steps to Reproduce

Use the Weekend possibility in the config dialog.

One Thing to note: I'm not sure if it is a bug. As test, if I chose directly Sa/So for the days, it worked correct. The problem is, that both schedules are triggered.

2022-04-18-183018_3440x1440_scrot

nielsfaber commented 2 years ago

Do you have the workday sensor running? What is its current state?

Micha-Btz commented 2 years ago

Sorry, was not finished jet. Yes, workday sensor is running and off (today).

nielsfaber commented 2 years ago

Can you please check if you're running version 3.2.8? You could see it in Configuration -> Devices (clicking on the scheduler device)

The reason I'm asking is that the last release contains changes which should tackle a potential issue with the workday sensor (in case of a holiday right after a weekend, which seemed to be the case here).

Micha-Btz commented 2 years ago

yes, I'm on 3.2.8

github-actions[bot] commented 2 years ago

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days