nielsfaber / scheduler-component

Custom component for HA that enables the creation of scheduler entities
GNU General Public License v3.0
655 stars 41 forks source link

Scheduler next run time not respecting workday holidays/ workday holidays not working #210

Closed BillyTheKid9588 closed 1 year ago

BillyTheKid9588 commented 2 years ago

Checklist

Card Version

v2.3.5

Component Version

No response

Bug description

It is a bank holiday in GB, England on 29/08/22, however the scheduler card states the next run time will be Monday.

Steps to reproduce

workday code is defined like this;

`# Example 1 configuration.yaml entry binary_sensor:

Created schedule Office - Heat To - 20.5, Workdays, Time 7am.

The next run time on the schedule states Monday at 7am.

If i amend my workday definition, such as below, next run time is Thursday.

Example 1 configuration.yaml entry

binary_sensor:

Additional info

No response

nielsfaber commented 2 years ago

Sorry for the late response. I'm a bit confused by contradictive info provided, please help me clarify.

If I understand correctly you defined working days to be: mon, thu, fri. And your schedule is configured to trigger on working days, Correct?

You state that 29/08/22 is a bank holiday, which is a Monday. However the code you share for the workday integration mentions 26/08/2022, which is a Friday. I assume we are talking about 29/08/22?

Did the schedule actually trigger on 29/08/22 ? The workday sensor in HA only can tell whether the current day is a working day or not. Hence scheduler cannot tell in advance (e.g. on Friday 26/08/2022) whether the next Monday will be a holiday. However, on the day itself, around 00:00, the scheduler will re-schedule (based on the state of the binary_sensor.workday_sensor) and skip the current day. This is a limitation of the workday integration, I don't see a way around this at this point.

github-actions[bot] commented 2 years ago

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days