Closed giovesoft closed 1 year ago
This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days
Ping
Already requested before and will not be added see #212
@nielsfaber can be closed
I do not agree with closing this ticket and the #212 because the issues reported in the #212 can be solved or are not really an issue:
"-5 hours can be the previous day": This is not a problem because you can compare just the hh:mm part of the date and not also the day, because the sunrise/sunset are not changing a lot from a day to another so you can use the sunrise/sunset times of the previous day without any problem.
"begin and end time for a timeslot may become reversed": you can have the same issue with the 2 hours range like in Sweden and other countries in the north.
"Additionally, scheduling a task with more than 2 hours offset is not meaningful, since the sun will be already completely up or down": this is not a problem because, for example, I want to turn off some lights during the night, I don't care if the sun is already down because I don't want to trigger the sun.
In my opinion you could enable a bigger range without issues and then the users will arrange it based on their locations.
This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days
Checklist
Proposal
The before/after sunrise/sunset setting has a limit of 2 hour. Please remove it or at least increase it.
Additional info
If the problem is the length of day/night in some areas, you could set the max equal to the min length of the day or night on that area.