nielsfaber / scheduler-component

Custom component for HA that enables the creation of scheduler entities
GNU General Public License v3.0
678 stars 46 forks source link

Defective Schedule if weekday not within optional period #349

Closed mburget closed 7 months ago

mburget commented 7 months ago

Checklist

Expected behavior

Not possible to get "defective schedule entities"

image

Actual behavior

Example:

  1. Setting a schedule which runs on mondays at 12:00
  2. In the option tab limit the schedule to a period wich do not include a monday e.g from 18.4.24 to 18.4.24
  3. saving the schedule leads to a defective schedule entity

Steps to Reproduce

100% reproducible by following the described steps: see actual behavior

Thanks for your work !

nielsfaber commented 7 months ago

18.4 is not on a monday, so this is indeed a schedule that cannot be processed (hence defective). I don't consider this a bug, it's a user error.

mburget commented 7 months ago

Ok but is there a way to get rid of these schedules entities? I did not find one. On my use case it happens when i'm reusing older complex schedules. After this false entry there seems to be no way back.

nielsfaber commented 7 months ago

There is a scheduler.remove service for deleting schedules. Ideally the card should be able to edit these as well, but this is currently not working well.