nielslange / smntcs-quantity-buttons-for-woocommerce

Display quantity buttons on WooCommerce product page.
https://wordpress.org/plugins/smntcs-woocommerce-quantity-buttons/
GNU General Public License v2.0
8 stars 4 forks source link

Rename handlers #31

Closed im-mortal closed 4 years ago

im-mortal commented 4 years ago

When I tried to dequeue the plugin js file, I found that the handler for it was custom-script, which wasn't very descriptive, not to mention that handler was already in use during theme development. I've changed handlers for both custom-script -> smntcswcqb-script and custom-style -> smntcswcqb-style, along with renaming custom.js and custom.css files to something meaningful (hopefully).

nielslange commented 4 years ago

Hello @im-mortal 👋 Sorry for my late reply and thank you so much for your contribution. I just merged your PR and will deploy a new version of the plug later today. If you give me your WordPress.org username, I'm happy to add you as a contributor to the plugin. 😉

im-mortal commented 4 years ago

Hey @nielslange, Thank you for merging my PR and, of course, the plugin. (it's amazing!) The contribution is rather irrelevant, but if it's desirable to list all the contributors, I'm @imm0rtal at WordPress.org. Thank you again and looking forward to seeing Quantity Buttons evolving!

nielslange commented 4 years ago

Hello @im-mortal 👋

Thank you for merging my PR and, of course, the plugin. (it's amazing!)

I'm glad to hear that!

The contribution is rather irrelevant, but if it's desirable to list all the contributors, I'm @imm0rtal at WordPress.org.

To me, it's a sign of appreciation. And this is how your WordPress.org profile page looked before and after. You are now officially a plugin developer/contributor! 🙌

Before:

![ORG-before](https://user-images.githubusercontent.com/3323310/81468641-01c1e000-920b-11ea-8732-942e8cf685a3.png)
After:

![ORG-after](https://user-images.githubusercontent.com/3323310/81468640-ff5f8600-920a-11ea-86c6-5e17de3bf109.png)
im-mortal commented 4 years ago

Thank you! That means a lot to me! 🎉 Stay safe!

nielslange commented 4 years ago

I'm glad to hear that and please stay safe as well! 🙏