search

nielsonm236 / NetMod-ServerApp

Reprogramming the Web_Relay_Con V2.0 HW-584 Network Module
72 stars 23 forks source link

Potential Bug: Two loops in ENC28J60 driver where timeout is needed to prevent hang #188

Closed nielsonm236 closed 1 year ago

nielsonm236 commented 1 year ago

Found two "while" loops in the ENC28J60 driver where a timeout is needed to prevent a potential hang. These loops are waiting for an ENC28J60 transmit to complete. I'm not entirely sure that any hang ever occurred in the driver at this point, but as mentioned in another issue there is an occasional hang when performing code uploads. It is possible this is where it happens. I don't really have a way to validate this with certainty, but implementing a timeout is easy to add to the code.

nielsonm236 commented 1 year ago

Addressed in build 20230803 1943