Open Fasanenpark opened 1 year ago
Hey @nielstron @Fasanenpark,
I've received my Bayernlüfter today and was very happy that there is already a HA-Extension available (thanks @nielstron!). In the current version the switches are not working - I think the current version is based on an older version of HA, as there should be a "set_percentage" method. So I've just changed "set_speed" -> "set_percentage" and it works as expected: https://github.com/domhaas/ha_bayernluefter/commit/20119710a0e59d41251ba5b6c3cb96b8b342b707
It takes max to "scan_interval" to receive the value set - for me this is ok, maybe there should be a repoll after setting the value.
The Timer-Switch is still not working (I don't need it, as I do every automation inside HA).
So, @nielstron can you confirm that you're running an older version of HA and if yes, maybe could we base this extension on the current HA?
Thank you in advance.
Cheers, Dom
I can confirm that I have not used HA for around 3 years now, so I would expect the version to be outdated :)
I appreciate any efforts to extend/update the package
@nielstron Thanks for your reply. So I gonna try to make it workable and coming back to you with a merge request ;)
Sounds great!
I have implemented your patch in main now but its lacking the additional polling after the change.
Thanks. Coming back to you.
Hey @nielstron,
I did some tests with my Hardware-Revision for the Bayernluefter and found out that the vendor did some changes on their firmware. I got the current FW-Revision (2.1): http://www.bayernluft.de/de/wlan32_changelist.html
As the Fan-Speed is working again with my change on the HA-Extension, there will be need to be some changes in the pyernluefter (see merge-request). For example the SystemOn-Value is coming as a string-value and your convert in pyernluefter to bool always casts "True". There are also some values missing from the export, like "Frostschutz". The vendor is currently as I understand those missing features from older FWs to the current one back, so I think it will take some time till we got all features back.
I think it would be goog to have a a new branch on both repos for the current FW-Revision to don't mix everything up, as there are for sure some breaking changes.
I'm no python-dev, so do not wonder for mistakes in my commits.
Hi @domhaas, I would prefer to keep the versions together in this repo, in the same branch as the changes appear minimal to me. I have pushed the bugfix you provided for pyernluefter (which was also a bug for revision 1!). For the missing fields we can either try to figure out automatically which fields are present before setting the sensors up or we add a field to the homeassistant configuration to let the user control the revision of their Bayernluefter.
Regarding your specific commits I didn't see any specific issues. Usually what you want to try though is to keep different changes in seperate branches/PRs so that a maintainer can merge those parts that are fine directly. By mixing changes into the same branch I had to pick out specific commits/changes manually (when for example the bug fix and removing the cached files was fine in https://github.com/nielstron/pyernluefter/pull/1 but I did not want to remove the testing for revision 1)
Hey @nielstron, thank you for your quick help & cooperation, much appreciated!
And i understand your objections about having multiple branches for every FW-Revision. I think you're right - if those FW-Switches are easy done, as it currently looks like.
I'm going to try everything in the next days and I will give you some feedback.
thanks for all your work. I just wanted to ask if it is possible to add the "Feuchtetransport" entity also to this integration? Would be nice 👍
The switch power button switch off the device but can not restart it. Also the fan control set percentage do not work. By setting another percentage there comes an error "error by calling service fan_setpercentage"
It would be also geat to have the sensor value "Feuchtetransport"