Closed henfri closed 5 years ago
Hello @henfri! Thanks for submitting the PR.
pyblnet/blnet_web.py
, following are the PEP8 issues :
Line 98:1: W293 blank line contains whitespace Line 101:28: E701 multiple statements on one line (colon) Line 128:1: W293 blank line contains whitespace Line 144:1: W293 blank line contains whitespace Line 168:29: E701 multiple statements on one line (colon) Line 170:32: E701 multiple statements on one line (colon) Line 189:17: W605 invalid escape sequence '\d' Line 189:33: W605 invalid escape sequence '\d' Line 190:16: W605 invalid escape sequence '\d' Line 210:76: W291 trailing whitespace Line 214:29: E701 multiple statements on one line (colon) Line 216:32: E701 multiple statements on one line (colon) Line 236:17: W605 invalid escape sequence '\d' Line 251:1: W293 blank line contains whitespace Line 254:70: W291 trailing whitespace Line 256:79: W291 trailing whitespace Line 257:80: E501 line too long (85 > 79 characters) Line 258:1: W293 blank line contains whitespace Line 260:12: E225 missing whitespace around operator Line 261:39: E701 multiple statements on one line (colon) Line 262:18: E225 missing whitespace around operator Line 262:18: E711 comparison to None should be 'if cond is None:' Line 263:11: E111 indentation is not a multiple of four Line 263:17: E225 missing whitespace around operator Line 265:12: E111 indentation is not a multiple of four Line 265:24: E225 missing whitespace around operator Line 265:43: E225 missing whitespace around operator Line 265:43: E711 comparison to None should be 'if cond is None:' Line 265:50: W291 trailing whitespace Line 266:14: E111 indentation is not a multiple of four Line 266:24: E225 missing whitespace around operator Line 266:39: E225 missing whitespace around operator Line 266:39: E711 comparison to None should be 'if cond is None:' Line 267:16: E111 indentation is not a multiple of four Line 267:19: E225 missing whitespace around operator Line 269:1: W293 blank line contains whitespace Line 270:1: W293 blank line contains whitespace Line 271:5: E303 too many blank lines (2) Line 273:58: W291 trailing whitespace
Thanks for your supposal! I'd like to note here though, that a higher level interface is not so useful if it is only implemented with one module. For now I'd like to simply call it a convenienve method for accessing data directly from the BLNet web module.
On the other hand, the BLnet module was supposed to handle this. It combines Web and Direct interface (where the latter uses a special communication protocol defined by TA while the former scraps the HTML-Interface).
I think I would prefer this method in the BLnet module as is meant to abstract from the actual way the data is retrieved which is exactly what you aim for in this proposal.
Hello,
ok, I'll wait for the update of the documentation. I was not aware that the BLnetweb and the BLNet direct should not be used directly. I suggest to reflect that in the documentation.
Once I have understood, I can then create the equivalent of this function in BlNet module.
Greetings, Hendrik
higher level interface added