nielstron / pyblnet

Automate wireless communication to UVR1611 via BL-NET
MIT License
6 stars 7 forks source link

Add higher level interface to blnet_web #12

Closed henfri closed 5 years ago

henfri commented 5 years ago

higher level interface added

pep8speaks commented 5 years ago

Hello @henfri! Thanks for submitting the PR.

nielstron commented 5 years ago

Thanks for your supposal! I'd like to note here though, that a higher level interface is not so useful if it is only implemented with one module. For now I'd like to simply call it a convenienve method for accessing data directly from the BLNet web module.

On the other hand, the BLnet module was supposed to handle this. It combines Web and Direct interface (where the latter uses a special communication protocol defined by TA while the former scraps the HTML-Interface).

I think I would prefer this method in the BLnet module as is meant to abstract from the actual way the data is retrieved which is exactly what you aim for in this proposal.

henfri commented 5 years ago

Hello,

ok, I'll wait for the update of the documentation. I was not aware that the BLnetweb and the BLNet direct should not be used directly. I suggest to reflect that in the documentation.

Once I have understood, I can then create the equivalent of this function in BlNet module.

Greetings, Hendrik