search

niemasd / TreeSwift

TreeSwift: Fast tree module for Python 3
https://niema.net/TreeSwift
GNU General Public License v3.0
75 stars 14 forks source link

Changed deroot function #15

Closed ekmolloy closed 4 years ago

ekmolloy commented 4 years ago

to have the same meaning as the DendroPy deroot function. This isn't a bug fix, but it definitely caused me some confusion when I was moving code that I had implemented in DendroPy over to TreeSwift. If you want to add this functionality without renaming the TreeSwift functions, you could accept this pull request and then change "deroot" to "unroot" and change "drop_edge_length_at_root" back to "deroot". Thanks for considering!

niemasd commented 4 years ago

Thanks so much, Erin! I've merged it and incorporated it into version 1.1.14!

ekmolloy commented 4 years ago

Thanks, Niema! This was my first accepted pull request, so I am pretty excited about it. Hope you have a great weekend.

On Fri, May 22, 2020 at 3:08 PM Niema Moshiri notifications@github.com wrote:

Thanks so much, Erin! I've merged it and incorporated it into version 1.1.14!

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/niemasd/TreeSwift/pull/15#issuecomment-632892024, or unsubscribe https://github.com/notifications/unsubscribe-auth/AB7GU4TQFERQGSLRVYXASDDRS3LTNANCNFSM4NICCZ2Q .