getting master instead of v1

morriswinkler-simple commented 7 years ago

██ go get -u gopkg.in/mattes/migrate.v1

will result in pulling master on https://github.com/mattes/migrate instead of branch v1, any idea how that can happen

niemeyer commented 7 years ago

How are you identifying that it's getting master instead of v1? Is the actual commit hash correct?

morriswinkler-simple commented 7 years ago

██ go get -u gopkg.in/mattes/migrate.v1

██ cd $GOPATH/src/gopkg.in/mattes/migrate.v1

██ git branch
* master

morriswinkler-simple commented 7 years ago

No wait, that's weared it looks like v1 branch, but all imports are regexed with

 s#gopkg.in/mattes/migrate.v1#github.com/mattes/migrate#g

morriswinkler-simple commented 7 years ago

the git ref looks like gopkg.in/mattes/migrate.v1 is 7 commits behind github.com/mattes/migrate branch v1

██ git log
commit 1dffba9fa56b3649de5fee6ba217af4e9424eacd
Merge: 62dba4f 964e6bc
Author: Matthias Kadenbach <matthias.kadenbach@gmail.com>
Date:   Sat May 6 16:25:42 2017 -0700

    Merge pull request #212 from mattes/v1-gopkg

    v1: github.com/mattes/migrate -> gopkg.in/mattes/migrate.v1

commit 964e6bc070748b85e90cf0cd443cecf513172db1
Author: Matthias Kadenbach <matthias.kadenbach@gmail.com>
Date:   Sat May 6 16:18:32 2017 -0700

    rewrite in readmes

commit 1887c0f3e348f809e6a5742ddab33d43354f7d37
Author: Matthias Kadenbach <matthias.kadenbach@gmail.com>
Date:   Sat May 6 16:13:08 2017 -0700

    rewrite paths

commit 62dba4f8ea9ed20b66f4495179248e01d8be91be
Author: Matthias Kadenbach <matthias.kadenbach@gmail.com>
Date:   Tue Apr 25 12:02:57 2017 -0700

    update travis branch

commit 78ca4eb0079b5745e9a03a077f34b980a9b39402
Merge: 9f14676 d21443f
Author: Matthias Kadenbach <matthias.kadenbach@gmail.com>
Date:   Tue Apr 25 11:35:40 2017 -0700

    Merge pull request #190 from alaczi/mssql_support

    MSSQL support

commit d21443f74ba6e030e9c699f925c452f78312df0e
Author: Andras Laczi <andras.laczi@sainsburys.co.uk>
Date:   Tue Apr 25 09:35:03 2017 +0100

    Remove go1.4 from travis as the ql package is not compatible and breaks the build
...skipping...
commit 7dde43471463c0ee6a4183e1b5a8239ae2aa3122

gopkg.in version is at 7dde43471463c0ee6a4183e1b5a8239ae2aa3122

so ya that explains it, no regex, after all, this commit still contains the original import paths that point's to github directly.

Any idea why gopkg.in is behind ?

niemeyer commented 7 years ago

Yes, you have a v1.3.1 tag pointing to 7dde43471463c0ee6a4183e1b5a8239ae2aa3122, and v1.3.1 > v1.

morriswinkler-simple commented 7 years ago

Thanks, obviously blind >:, i guess you can close this issue.

niemeyer / gopkg

getting master instead of v1 #55