search

niemopen / niem-model

The NIEM reference data model
Other
11 stars 6 forks source link

Version 6.0 Internal Review - NCIC codes #87

Closed aprilm99 closed 10 months ago

aprilm99 commented 11 months ago

I reviewed the NCIC codes especially and found a few that needed to be added, updated or deleted. I am attaching the facet spreadsheet.

I also noticed a few descriptions with double spaces but did not include them in the spreadsheet.

niem-facet-6.0-update.xlsx

Shunbah commented 11 months ago

Jim Cabral volunteered to work this in today's NTAC-TSC. The TSC commented that xsd/codes/ncic.xsd schema and the docs/niem-6.0-codes.xlsx files need to be updated. There is one definition that is blank. That one needs to keep the existing definition to pass validation. Contact April Mitchell with any questions.

mikehulme commented 11 months ago

I can help with this as well or instead of Jim. I am familiar with this topic.

cabralje commented 11 months ago

Mike,

I would appreciate the help. Can you generate the pull request?

__ Jim Cabral 502-640-4970

From: Mike Hulme @.***> Sent: Tuesday, October 17, 2023 10:52 AM To: niemopen/niem-model Cc: Jim Cabral; Assign Subject: Re: [niemopen/niem-model] Version 6.0 Internal Review - NCIC codes (Issue #87)

I can help with this as well or instead of Jim. I am familiar with this topic.

— Reply to this email directly, view it on GitHubhttps://github.com/niemopen/niem-model/issues/87#issuecomment-1766582992, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AA4SQQCODXP3P6ZFGEHGSS3X72LSVAVCNFSM6AAAAAA54HQ7R6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONRWGU4DEOJZGI. You are receiving this because you were assigned.Message ID: @.***>

mikehulme commented 11 months ago

Yes

albeach commented 11 months ago

Jim & Mike,Once the pull request is generated I can merge with the dev branch if there are no conflicts. Let me know if there are any additional steps for code review.v/r,AubreyOn Oct 17, 2023, at 11:26 AM, Jim Cabral @.***> wrote: Mike,

I would appreciate the help. Can you generate the pull request?

__

Jim Cabral

502-640-4970

From: Mike Hulme @.***>

Sent: Tuesday, October 17, 2023 10:52 AM

To: niemopen/niem-model

Cc: Jim Cabral; Assign

Subject: Re: [niemopen/niem-model] Version 6.0 Internal Review - NCIC codes (Issue #87)

I can help with this as well or instead of Jim. I am familiar with this topic.

—

Reply to this email directly, view it on GitHubhttps://github.com/niemopen/niem-model/issues/87#issuecomment-1766582992, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AA4SQQCODXP3P6ZFGEHGSS3X72LSVAVCNFSM6AAAAAA54HQ7R6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONRWGU4DEOJZGI.

You are receiving this because you were assigned.Message ID: @.***>

—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you are subscribed to this thread.Message ID: @.***>

mikehulme commented 10 months ago

Completed and emailed the ncic codes XML schema and spreadsheet to Scott Renner for incorporation into the release. @aprilm99 - I attached the facets spreadsheet with two added columns stating the action taken. niem-facet-6.0-update-applied.xlsx

iamdrscott commented 10 months ago

Completed by https://github.com/niemopen/niem-model/commit/8533fb1ef0b86b87ec98e03c7071ee8fab6bf409