search

nienbo / cache-buildkite-plugin

Tarball, Rsync & S3 Cache Kit for Buildkite. Supports Linux, macOS and Windows
https://buildkite.com/plugins
MIT License
67 stars 39 forks source link

[FEATURE REQUEST] - Don't download cache if it exists #36

Open calvinbui opened 3 years ago

calvinbui commented 3 years ago

By editing Buildkite's git-clean-flags we can exclude cache files or directories from being removed during checkout. If this is so, this plugin could check if the cache files/folders already exist and skip restoring it.

This could be done with a key like skip_restore_existing or something.

gencer commented 3 years ago

Yup! Great idea.

I will prepare after other pending bug.

gencer commented 3 years ago

I've evaluated possible use cases and, I'm not sure If checking existing directories are reliable or not. For example, you may change cache folders on next builds which leads to incorrect match. However, It is still possible to do so. I'll handle this on v2.5.0. Feel free to send your PR if you have any proposal.

stale[bot] commented 3 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

gencer commented 3 years ago

Not stale.

stale[bot] commented 2 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] commented 2 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] commented 2 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

gencer commented 2 years ago

Not stale

stale[bot] commented 2 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.