search

nienbo / cache-buildkite-plugin

Tarball, Rsync & S3 Cache Kit for Buildkite. Supports Linux, macOS and Windows
https://buildkite.com/plugins
MIT License
67 stars 39 forks source link

eliminate download progress in the log #58

Open xxchan opened 1 year ago

xxchan commented 1 year ago

This produced 5000 line of logs

image
xxchan commented 1 year ago

Oh, I think I can suppress log by 

  s3:
    args: '--no-progress'

(Not sure whether it should be disabled by default

gencer commented 1 year ago

Can you try to use args with: --no-progress and test with it?

Let me know the result.

gencer commented 1 year ago

Oh, I think I can suppress log by

  s3:
    args: '--no-progress'

(Not sure whether it should be disabled by default

Just posted the same thing. Seems you already found the solution.

If it works, we can definitely consider adding this as a default value.

xxchan commented 1 year ago

It works https://github.com/risingwavelabs/risingwave/pull/8967 Log size reduced 400KB

gencer commented 1 year ago

Thanks for the feedback. 🥳

I'll make sure --no-progress is in default arguments.

Also, there will be a check for the existing user-provided arguments. So, no duplicate arguments send to the AWS CLI. (This will make sure your CI will not fail when you upgrade to 2.4.14 (upcoming release))

I'll leave this issue open until this gets internally solved.