search

nienbo / cache-buildkite-plugin

Tarball, Rsync & S3 Cache Kit for Buildkite. Supports Linux, macOS and Windows
https://buildkite.com/plugins
MIT License
67 stars 39 forks source link

Discard broken S3 downloads #65

Closed bradleyayers closed 11 months ago

gencer commented 12 months ago

Hi @bradleyayers!

Thanks for the PR 🎉

However, CI check failed. 🙄

bradleyayers commented 11 months ago

@gencer I've fixed the tests and added a new test for this scenario. I went with a soft failure open and used return 0 rather than exit 0 to return just from the restore() function rather than killing the entire script.