nienbo / cache-buildkite-plugin

Tarball, Rsync & S3 Cache Kit for Buildkite. Supports Linux, macOS and Windows
https://buildkite.com/plugins
MIT License
67 stars 39 forks source link

Don't upload to S3 on local cache hit #66

Closed franklin-ross closed 4 weeks ago

franklin-ross commented 9 months ago

When using S3 with save-cache: true and the local cache hits, we seem to then upload the local cache to S3 in the post-command step. That doesn't seem necessary as a local cache hit implies the same entry already exists in S3 and was previously downloaded.

image


For comparison, here's what happens when the local cache misses and we download from S3, no 10 second upload:

image

calvinbui commented 4 weeks ago

i'm taking a look

franklin-ross commented 1 week ago

🎉