search

nienbo / cache-buildkite-plugin

Tarball, Rsync & S3 Cache Kit for Buildkite. Supports Linux, macOS and Windows
https://buildkite.com/plugins
MIT License
67 stars 39 forks source link

Create tar file atomically #7

Closed djmarcin closed 4 years ago

djmarcin commented 4 years ago

I believe this should fix https://github.com/gencer/cache-buildkite-plugin/issues/6

gencer commented 4 years ago

Thanks for the PR! 🎉

One question. Shouldn't we also use -f option on mv? Because if target exists, it will prompt for the overwrite operation I believe. Please correct me If I'm wrong on this.

$ mv --help
...
  -f, --force                  do not prompt before overwriting
...
djmarcin commented 4 years ago

It doesn't hurt, but I thought mv only prompted if you used mv -i. Added.

gencer commented 4 years ago

Thanks for the update!

djmarcin commented 4 years ago

Tested the tarball storage path using #master 👍

gencer commented 4 years ago

Thanks for the confirmation. I believe you tested against macOS, right? So I want to test it on Linux. However, I am pretty sure it will be OK on Linux too. As both works at similar level.

djmarcin commented 4 years ago

I have builds running on both macOS and Linux :)

gencer commented 4 years ago

Thanks for the re-confirmation @djmarcin! I am releasing a new version now.