search

niess / python-appimage

AppImage distributions of Python
https://python-appimage.readthedocs.io/en/latest/
GNU General Public License v3.0
170 stars 24 forks source link

Fix: tests for 2.7 and 3.5 #33

Closed anki-code closed 3 years ago

anki-code commented 3 years ago

Related to #31 #32

anki-code commented 3 years ago

Hi @niess! Please take a look.

niess commented 3 years ago

Fine, I see. I am just wondering about the following. My understanding is that it fails in 2.7 and 3.5 because the pip version differs. Right? But let's say that the pip versions gets updated for the 3.5 AppImage. Then the behaviour of app build would no more be correct isn't it?

If so, wouldn't it be better to check the pip version instead of the python one. E.g. by issuing a system('AppRun -m pip --version ') first and parsing out the result.

anki-code commented 3 years ago

@niess yep, take a look again ;)

niess commented 3 years ago

@anki-code Great :) I'll try the merge

niess commented 3 years ago

It worked out. Great :) Thank you again for patching this :)