search

niess / python-appimage

AppImage distributions of Python
https://python-appimage.readthedocs.io/en/latest/
GNU General Public License v3.0
170 stars 24 forks source link

Feature Request #54

Closed Derf000 closed 1 year ago

Derf000 commented 2 years ago

Hi, very very very good jobs...

Is it possible to add supports to tcl/tk v8.6 in "recent" (>= 3.6) appimages ? It would be very great.

By the way thank for you work

niess commented 1 year ago

Hello @gitUser000,

thank you for pointing this out. The issue was that I hard-coded the search location for Tcl/Tk libraries, but the installation prefix (recently?) changed in manylinux Docker images. I updated python-appimage in order to locate Tcl/Tk path dynamically, using the corresponding host tclsh executable. This should be more robust in the future if the installation prefix changes again. Now the proper Tcl/Tk versions should be bundled in AppImages. Note that the bundled version of Tcl/Tk actually depends on the manylinux tag, not on the Python version. That is:

Thus, if you use a manylinux2014 image, then you should have Tcl/Tk 8.6.

Derf000 commented 1 year ago

Hi, checked with python3.9.14-cp39-cp39-manylinux2014_x86_64.AppImage : OK Many thanks for this very fast fix/update.

niess commented 1 year ago

Great. I am closing then.