search

niess / python-appimage

AppImage distributions of Python
https://python-appimage.readthedocs.io/en/latest/
GNU General Public License v3.0
170 stars 24 forks source link

Allow < and @ sign in requirements.txt #66

Closed overbost closed 2 months ago

overbost commented 1 year ago

Every line in requirements is injected in shell, if there are "<" or "<"= sign it break because "<" is special symbol in shell.

Before this line the line should be incorporated in apices like:

"'{r}'".format(r=requirement)

# not works
$ pip install package<=0.5
# works
$ pip install 'package<=0.5'

i temporary solved by adding apices in my requirements

EDIT git repository with specific branch doesn't work, and putting apices doesn't solve. I must use main branch

# not works
git+https://github.com/overbost/myrepo@devbranch
niess commented 11 months ago

Hello @overbost ,

thank you for pointing this out. Implementing your proposal seems straightforward. But, unfortunately, it does not seem to solve the second issue, which I do not quite understand.

I currently have little availability for this project. Since there is an easy solution (manually wrapping with ''), I'll leave this as so for now. But, I am open to a PR, if someone manages to solve both issues.

dotzborro commented 3 months ago

@overbost fyi git requirements are working now

related PR: https://github.com/niess/python-appimage/pull/73