search

niessner / VoxelHashing

[Siggraph Asia 2013] Large-Scale, Real-Time 3D Reconstruction
Other
670 stars 201 forks source link

A question about the function “deleteHashEntryElement” #15

Closed lelleMU closed 6 years ago

lelleMU commented 6 years ago

When I read the code, I had a question about the code in the line 791 in VoxelUtilHashSDF.h prev.offset = curr.offset; As long as I am concered, in this part, you want the previous hash entry to point to the next and next hash entry so that you skip the current entry to delete it from the linked list. So in my view the code should be like prev.offset += curr.offset; for example, the offset of previous entry is 1 and it points to current entry which one we want to delete and the offset of the current entry is 2 which points to the next valid entry then we need to fix the offset of the previous entry to 3 so that we can skip the current entry and point it to the next valid entry. That's what I think, I am not sure if I get the right understanding of your code, I hope you can make it clear to me. THX!

lelleMU commented 6 years ago

well , I find I made a mistake

zyuanbing commented 3 years ago

When I read the code, I had a question about the code in the line 791 in VoxelUtilHashSDF.h prev.offset = curr.offset; As long as I am concered, in this part, you want the previous hash entry to point to the next and next hash entry so that you skip the current entry to delete it from the linked list. So in my view the code should be like prev.offset += curr.offset; for example, the offset of previous entry is 1 and it points to current entry which one we want to delete and the offset of the current entry is 2 which points to the next valid entry then we need to fix the offset of the previous entry to 3 so that we can skip the current entry and point it to the next valid entry. That's what I think, I am not sure if I get the right understanding of your code, I hope you can make it clear to me. THX!

Hi, have you get the test data, and how to get it?