search

niesteszeck / idDHTLib

DHT11 & DHT22 interrupt driven library for arduino
GNU Lesser General Public License v3.0
18 stars 10 forks source link

DHT22 tuning #3

Closed Dessimat0r closed 11 years ago

Dessimat0r commented 11 years ago

Added code to fix DHT22.

niesteszeck commented 11 years ago

WOW, this is to much code. There's a lot of changes that are not necessary, that's why I make a new branch called dht22_tunning, to put only the changes that are important. In branch dht22_bug_detect is the history of all the things that we try to find what was making the dht22 sensors to not work properly. The plan to dht22_tunning branch is to add only the important changes that make a difference, so for example the changes to add an serial output is not necessary and that's why I started with the commit 7c9ca5 "add 10us to detect a valid 0 or 1". The other important change is to change the 40 to 25 us delay on the acquire method (I'm doing a cherry pick of this commit right now), and for last is the final tuning that you make that adds 10 us more to the part that discriminate between a 1 and a 0, please make a pull request that only reflect this change

Dessimat0r commented 11 years ago

Ahh, ok -- I thought some of the debug code you wanted to keep in the library :)

On 1 August 2013 15:02, Nicolas notifications@github.com wrote:

WOW, this is to much code. There's a lot of changes that are not necessary, that's why I make a new branch called dht22_tunning, to put only the changes that are important. In branch dht22_bug_detect is the history of all the things that we try to find what was making the dht22 sensors to not work properly. The plan to dht22_tunning branch is to add only the important changes that make a difference, so for example the changes to add an serial output is not necessary and that's why I started with the commit 7c9ca5 "add 10us to detect a valid 0 or 1". The other important change is to change the 40 to 25 us delay on the acquire method (I'm doing a cherry pick of this commit right now), and for last is the final tuning that you make that adds 10 us more to the part that discriminate between a 1 and a 0, please make a pull request that only reflect this change

— Reply to this email directly or view it on GitHubhttps://github.com/niesteszeck/idDHTLib/pull/3#issuecomment-21938185 .

niesteszeck commented 11 years ago

No, to avoid to loose it i'll maintain this branch (..bug_detect), but not merge it into master

niesteszeck commented 11 years ago

Hey @Dessimat0r, I have tested our mods (the 40->25, the 135->145 and yours 90->100) on a DHT11 (actually 2 and at the same time) and it worked fine! so if you make your pull request we are ready to publish a final version of the lib.

Dessimat0r commented 11 years ago

That's great :D I'll do it as soon as possible. I had some bad days yesterday and the day before with leg pain, but today it's been okay (I was also drinking and had a hangover).

niesteszeck commented 11 years ago

Nice to hear that you are better. I'm waiting for your pull request, I have ready the README so it reflect your effort so after you push your commit of the 90->100 change y push the readme and all is ready