niflows / nipype1-workflows

Legacy workflows from Nipype 1.x
4 stars 3 forks source link

Update setup.cfg #3

Closed satra closed 4 years ago

satra commented 4 years ago

include data in the package.

satra commented 4 years ago

@cni-md - could you please check if this branch solves #2 ?

effigies commented 4 years ago

@satra I tried building the sdist with your fix, and it didn't work. Looking into the documentation, it appears that means to respect MANIFEST.in. Instead, I updated the package_data option, and that resolved it, at least locally. I pushed that to your branch.

Assuming this resolves @cni-md's issue, we should update the Python skeleton in niflow-manager.

cni-md commented 4 years ago

A pip install git+https://github.com/niflows/nipype1-workflows.git@fix/include-data did not work for me. It is compaining the missing setup.py in the main niflow folder.

pip install git+https://github.com/niflows/nipype1-workflows.git@fix/include-data Collecting git+https://github.com/niflows/nipype1-workflows.git@fix/include-data Cloning https://github.com/niflows/nipype1-workflows.git (to revision fix/include-data) to /scratch/spralat_dti/tmp/pip-req-build-twlqstpi Running command git clone -q https://github.com/niflows/nipype1-workflows.git /scratch/spralat_dti/tmp/pip-req-build-twlqstpi Running command git checkout -b fix/include-data --track origin/fix/include-data Switched to a new branch 'fix/include-data' Branch fix/include-data set up to track remote branch fix/include-data from origin. ERROR: Command errored out with exit status 1: command: /users/jstadler/studien/spralatP3/bin/python3 -c 'import sys, setuptools, tokenize; sys.argv[0] = '"'"'/scratch/spralat_dti/tmp/pip-req-build-twlqstpi/setup.py'"'"'; file='"'"'/scratch/spralat_dti/tmp/pip-req-build-twlqstpi/setup.py'"'"';f=getattr(tokenize, '"'"'open'"'"', open)(file);code=f.read().replace('"'"'\r\n'"'"', '"'"'\n'"'"');f.close();exec(compile(code, file, '"'"'exec'"'"'))' egg_info --egg-base /scratch/spralat_dti/tmp/pip-req-build-twlqstpi/pip-egg-info cwd: /scratch/spralat_dti/tmp/pip-req-build-twlqstpi/ Complete output (5 lines): Traceback (most recent call last): File "", line 1, in File "/users/jstadler/studien/spralatP3/lib/python3.5/tokenize.py", line 454, in open buffer = _builtin_open(filename, 'rb') FileNotFoundError: [Errno 2] No such file or directory: '/scratch/spralat_dti/tmp/pip-req-build-twlqstpi/setup.py'

ERROR: Command errored out with exit status 1: python setup.py egg_info Check the logs for full command output

pip install -e /scratch/spralat_dti/tmp/pip-req-build-twlqstpi/package/setup.pyworked well

effigies commented 4 years ago

pip install -e isn't a good test, since it uses the repository itself as the installed directory, and the files are definitely there. Could you try:

git clone -b fix/include-data https://github.com/niflows/nipype1-workflows.git
pip install nipype1-workflows/package
cni-md commented 4 years ago

@effigies Yes, this is working. Thanks a lot.

effigies commented 4 years ago

Great! Thanks for the confirmation.